Skip to content

Add unit test for uploader.spec.ts #9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add unit test for uploader.spec.ts #9543

wants to merge 5 commits into from
+126 −0

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Nov 26, 2025 •
edited
Loading

Description

Going through my usual exercise of trying out new AI by having it write unit tests - this time, AGY + Gemini 3 wrote tests for the file uploader used for hosting deploy.

This is part of a larger effort to increase the test coverage for this repo.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 26, 2025

Summary of Changes

Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new unit test file for the uploader.ts module, which is a critical component for handling file uploads during hosting deployments. The primary goal is to enhance test coverage by validating the Uploader's core functionalities, such as initialization, file hashing, and the process of populating file versions. The tests were generated with the assistance of an AI, contributing to a broader initiative to improve the repository's overall test coverage.

Highlights

  • New Unit Test File: A new unit test file, uploader.spec.ts, has been added to test the Uploader class responsible for hosting deployments.
  • Uploader Initialization Test: The new test suite includes a test case to ensure the Uploader class initializes correctly with provided configuration.
  • File Hashing and Population Logic: Comprehensive tests have been added to verify the Uploader's functionality for hashing files and populating file versions, including interactions with the Client API and file system operations.
  • Testing Frameworks: The tests utilize chai for assertions and sinon for robust mocking of dependencies like fs, zlib, and the internal Client.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds unit tests for the Uploader class, which is a great step towards increasing test coverage. The tests cover the initialization and the main file processing logic, including hashing, populating, and uploading. My review includes a few suggestions to improve the test code's quality and maintainability, such as improving typings in the mock queue, removing unused code, and refactoring duplicated logic in the stream mocks. Overall, this is a solid contribution.

@joehan joehan requested a review from MichaelDoyle December 1, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelDoyle MichaelDoyle Awaiting requested review from MichaelDoyle

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joehan